Skip to content

Optimize and generalize releases - #27

Merged
alexlanz merged 6 commits into
mainfrom
release-optimizations
Aug 29, 2025
Merged

Optimize and generalize releases#27
alexlanz merged 6 commits into
mainfrom
release-optimizations

Conversation

@alexlanz

Copy link
Copy Markdown
Member

No description provided.

@alexlanz
alexlanz requested a review from SirCotare August 29, 2025 11:40
Comment thread .github/workflows/publish.yml Outdated
- uses: aboutbits/github-actions-base/git-commit-and-push-all@v2
with:
message: '${{ github.event.inputs.version }}'
- uses: aboutbits/github-actions-base/git-create-or-update-tag@v2

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be redundant because the github release will also create the tag if necessary.
Also this would add the tag before publishing the package (which might still fail).

@alexlanz
alexlanz requested a review from SirCotare August 29, 2025 13:57

@SirCotare SirCotare left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 💯

@alexlanz
alexlanz merged commit 6589385 into main Aug 29, 2025
1 check passed
@alexlanz
alexlanz deleted the release-optimizations branch August 29, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants